Skip to content

(Feature) Allow multiple random-address generation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fvictorio merged 4 commits into from
Apr 12, 2018
Merged

(Feature) Allow multiple random-address generation #4

fvictorio merged 4 commits into from
Apr 12, 2018

Conversation

@fernandomg
Copy link
Contributor

@fernandomg fernandomg commented Apr 12, 2018

This PR changes the randomAddress command to random-address, to maintain a consistency with commands naming of eth-cli.

Now returns the checksummed Ethereum address.

And adds the option to specify the amount of addresses to be randomly generated.

$ eth random-address 10
0xfBC8256f2D3dB9dF79F9443783a98fE5690f5528
0x22862aeB499bA24fEcc6c470D9d5e10340A1c184
0x66b13a8cDF90f1F1eBfdA66Fec8178ACB5fDC85a
0x018fB555B648c35c207Ae7Cc1991411c9F21DA91
0x0B0602b21546B8Fb1e6B1f5C99C64d072A4B2293
0xEb95807DcF75d75bC3b42a891E90Aa76a40bF374
0xE19dc0f699b4Ed8c20F4C7E33e1b126763Ba6395
0x9b3691c862164b67c15cB3A7E00d98D872330d2C
0x0Ad4A2384731B5482e717AdB3cdEd018089255Ed
0xCC403B99539D2d0C3A3054E773D5808368b548A4

@fernandomg fernandomg requested a review from fvictorio April 12, 2018 18:29
@fernandomg fernandomg self-assigned this Apr 12, 2018
fvictorio
fvictorio approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks

@fvictorio fvictorio merged commit 6e263c9 into protofire:master Apr 12, 2018
Windows81 pushed a commit to Windows81/ETH-CLI that referenced this pull request Oct 13, 2025
@lilsunny243
Merge pull request protofire#4 from lilsunny243/dependabot/npm_and_ya…
7eae41b 
…rn/json5-2.2.3

Bump json5 from 2.1.0 to 2.2.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fvictorio fvictorio fvictorio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fernandomg fernandomg

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fernandomg @fvictorio