Fix build on MinGW32 #3485
Merged
Fix build on MinGW32 #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This excludes cygwin and mingw from using the self implemented functions.
strdup is not part C or C++ standard but POXIS function. Several compilers failed to compile strdup or generate warnings.
|
This fixes #3483 |
xfxyjwf
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict the io_win32 change and only enable that for MSVC, because:
This is a temporary fix to make the build pass. We can revisit this if support on MinGW32 is required. Note that the pre-built protoc artifacts are built under mingw32. With this change, they won't use the long path support code and would rely on the platform APIs for path support.