Skip to content

Conversation

@qdequippe
Copy link

Supports The PHP Installer for Extensions (PIE)

https://github.com/php/pie/blob/1.4.x/docs/extension-maintainers.md

@qdequippe qdequippe requested a review from a team as a code owner December 4, 2025 14:36
@qdequippe qdequippe requested review from bshaffer and removed request for a team December 4, 2025 14:36
@google-cla
Copy link

google-cla bot commented Dec 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@zhangskz zhangskz added the php label Dec 5, 2025
@zhangskz
Copy link
Member

zhangskz commented Dec 5, 2025

Please sign the CLA before we can review your PR.

@SpencerMalone
Copy link
Contributor

Does this impact the non-extension php library? The php/ directory publishes both a pure PHP composer library, and under php/ext/google/protobuf has the C extension. I would have expected us to have 2 separate composer projects to support the two separate artifacts.

@qdequippe
Copy link
Author

hello @zhangskz I signed the CLA

@qdequippe
Copy link
Author

Does this impact the non-extension php library? The php/ directory publishes both a pure PHP composer library, and under php/ext/google/protobuf has the C extension. I would have expected us to have 2 separate composer projects to support the two separate artifacts.

I don't think there is any impact on the existing php library but I will double check with the PIE's core contributors.

@asgrim
Copy link

asgrim commented Dec 16, 2025

Due to the way Packagist works, you can only have EITHER a PHP library, OR a PIE extension in a project's composer.json. This would therefore break the existing PHP library.

This has been brought up before: php/pie#261

The solution, as far as I can tell, is to have a separate repo for the PHP library and PIE extension components.

@bshaffer
Copy link
Contributor

Thanks @asgrim , that's a nonstarter for this PR then. We will take a look at some other options.

@asgrim
Copy link

asgrim commented Dec 16, 2025

Thanks @asgrim , that's a nonstarter for this PR then. We will take a look at some other options.

I just did some exploring, and was confused how the PHP library even works at the moment (since Packagist looks for the root composer.json, which doesn't exist in this repo); then I discovered it is actually split/mirrored: https://github.com/protocolbuffers/protobuf-php

You could potentially take a similar approach and split/mirror the subdirectory; https://github.com/protocolbuffers/protobuf/tree/main/php/ext/google/protobuf (which could have its own composer.json similar to what is proposed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants