-
Notifications
You must be signed in to change notification settings - Fork 16k
[php][ext] Supports PIE #24694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[php][ext] Supports PIE #24694
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Please sign the CLA before we can review your PR. |
|
Does this impact the non-extension php library? The |
|
hello @zhangskz I signed the CLA |
I don't think there is any impact on the existing php library but I will double check with the PIE's core contributors. |
|
Due to the way Packagist works, you can only have EITHER a PHP library, OR a PIE extension in a project's This has been brought up before: php/pie#261 The solution, as far as I can tell, is to have a separate repo for the PHP library and PIE extension components. |
|
Thanks @asgrim , that's a nonstarter for this PR then. We will take a look at some other options. |
I just did some exploring, and was confused how the PHP library even works at the moment (since Packagist looks for the root You could potentially take a similar approach and split/mirror the subdirectory; https://github.com/protocolbuffers/protobuf/tree/main/php/ext/google/protobuf (which could have its own |
Supports The PHP Installer for Extensions (PIE)
https://github.com/php/pie/blob/1.4.x/docs/extension-maintainers.md