Avoid linker errors when compiling for AOT. #21806
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Using Marshal.SizeOf(typeof(T)) or Enum.GetValues(typeof(T)) can cause AOT builds to fail when including the Google.Protobuf NuGet package and using the tools from a recent enough .NET SDK (9.0.300 or possibly earlier). Set <TrimmerSingleWarn>false</TrimmerSingleWarn> and <TreatWarningsAsErrors>True</TreatWarningsAsErrors> to see something like this: /_/csharp/src/Google.Protobuf/Collections/RepeatedField.cs(714): AOT analysis error IL3050: Google.Protobuf.Collections.RepeatedField`1.TryGetArrayAsSpanPinnedUnsafe(FieldCodec`1<T>,Span`1<Byte>&,GCHandle&): Using member 'System.Runtime.InteropServices.Marshal.SizeOf(Type)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Marshalling code for the object might not be available. Use the SizeOf<T> overload instead. [/src/xxxx/xxxx.csproj] /root/.nuget/packages/microsoft.dotnet.ilcompiler/9.0.5/build/Microsoft.NETCore.Native.targets(317,5): error MSB3073: The command ""/root/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.5/tools/ilc" @"obj/Release/net9.0/linux-x64/native/RootApp.HubServer.ilc.rsp"" exited with code -1. [/src/xxxx/xxxx.csproj]
henric-root
force-pushed
the
aot-link-errors-with-sdk-9
branch
from
7af7fa0 to
0549c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Marshal.SizeOf(typeof(T))orEnum.GetValues(typeof(T))can cause AOT builds to fail when including the Google.Protobuf NuGet package and using the tools from a recent enough .NET SDK (9.0.300 or possibly earlier).Set
<TrimmerSingleWarn>false</TrimmerSingleWarn>and<TreatWarningsAsErrors>True</TreatWarningsAsErrors>to see something like this: