make hasOptionalKeyword function public #17714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mscheong01
force-pushed
the
mscheong01-patch-1
branch
from
7c860b0
to
03fa476
Compare
|
hasOptionalKeyword() was intentionally removed as part of 1aeacd4 since these API's are proto2/proto3 specific and break under Editions (https://protobuf.dev/editions/overview/). Most users of hasOptionalKeyword() likely want to move to use FieldDescriptor.hasPresence() instead. Can you elaborate on what you mean by "to check if the field is private or not"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am currently migrating my third party Kotlin protobuf code generation libaray, krotoDC from protobuf v3 to v4.
However, I noticed that
FieldDescriptor::hasOptionalKeyword()has become package-private. My library relies on this api to check if the field is private or not. can we please make this function public again?