-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bazel rules for java and kotlin #17320
Open
deannagarcia
wants to merge
5
commits into
protocolbuffers:main
Choose a base branch
from
deannagarcia:upgradeJavaBazel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deannagarcia
requested review from
mkruskal-google
and removed request for
a team
July 2, 2024 21:49
deannagarcia
added
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 2, 2024
mkruskal-google
approved these changes
Jul 2, 2024
github-actions
bot
removed
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 2, 2024
deannagarcia
added
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 2, 2024
github-actions
bot
removed
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 2, 2024
deannagarcia
added
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 2, 2024
github-actions
bot
removed
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 2, 2024
deannagarcia
added
🅰️ safe for tests
Mark a commit as safe to run presubmits over
labels
Jul 2, 2024
github-actions
bot
removed
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 2, 2024
deannagarcia
added
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 3, 2024
github-actions
bot
removed
the
🅰️ safe for tests
Mark a commit as safe to run presubmits over
label
Jul 3, 2024
We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment. This PR is labeled |
github-actions
bot
added
the
inactive
Denotes the issue/PR has not seen activity in the last 90 days.
label
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our dependencies on
rules_java
,rules_jvm_external
andrules_kotlin
(which was renamed fromio_bazel_rules_kotlin
). These new versions support bazel 7 which should allow us to migrate.