Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace system python with hermetic python from rules_python #15850

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mering
Copy link
Contributor

@mering mering commented Feb 15, 2024

Depends on #15849

Supersedes #16829

@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 8, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 8, 2024
@mering
Copy link
Contributor Author

mering commented May 8, 2024

@zhangskz could you trigger them again please?

@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 8, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 8, 2024
@mering mering force-pushed the rules_python_headers branch 3 times, most recently from 86512e6 to dbe4c06 Compare May 8, 2024 19:09
@mering
Copy link
Contributor Author

mering commented May 8, 2024

@zhangskz I configured the hermetic toolchain now. Could you please trigger tests again?

zhangskz
zhangskz previously approved these changes May 8, 2024
@zhangskz zhangskz dismissed their stale review May 8, 2024 20:03

Accident

@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 8, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 8, 2024
copybara-service bot pushed a commit that referenced this pull request May 13, 2024
copybara-service bot pushed a commit that referenced this pull request May 13, 2024
copybara-service bot pushed a commit that referenced this pull request May 13, 2024
copybara-service bot pushed a commit that referenced this pull request May 13, 2024
Copy link

github-actions bot commented Oct 2, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants