Remove googletest.h header from stringprintf.cc #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem to be necessary here, and it pulls other testing headers during compilation of release protobuf.
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test. |
|
ok to test |
|
Friendly ping. This is very simple change to review. |
|
Sorry, I kicked off the Jenkins tests but forgot to check back after the tests finished. |
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Remove googletest.h header from stringprintf.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem to be necessary here, and it pulls other testing headers
during compilation of release protobuf.