Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing PY2AND3 srcs_versions attributes to Python Bazel build targets #1402

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

davidzchen
Copy link
Contributor

This is to fix the build break in tensorflow/tensorflow#1289

+cc @martinwicke @podsvirov

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Apr 8, 2016

@haberman to review the change. Do we currently have test coverage for bazel on Jenkins?

@davidzchen
Copy link
Contributor Author

Ping

@podsvirov
Copy link
Contributor

Hello @davidzchen!
I love C ++ and well versed in CMake.
I contributed to the project in terms of improvement protobuf CMake project.
How can I help in this case?
I read about a variable srcs_version = "PY2AND3", but do not know where it can be used in C ++ code? Teach me :-)

@davidzchen
Copy link
Contributor Author

@podsvirov, thanks for your enthusiasm. This particular PR, and the srcs_version = "PY2AND3" attribute, is specifically for the Bazel build for protobuf. I don't think that the CMake build for protobuf has this issue.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Apr 14, 2016

ping @haberman

@davidzchen
Copy link
Contributor Author

davidzchen commented Apr 19, 2016

Can someone take a look at this? This is blocking tensorflow/tensorflow#1289.

@xfxyjwf xfxyjwf merged commit 83a7a5e into protocolbuffers:master Apr 19, 2016
@martinwicke
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants