Skip to content

Fix remote view indicators by correctly reading the item prototype from cursor ghost #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix remote view indicators by correctly reading the item prototype from cursor ghost #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f11348
Fix remote view indicators but correctly reading the item prototype f…
CodeW0lf Feb 28, 2025
c1e4859
fix spacing
CodeW0lf Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions control.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,18 @@ end
local function render_for_player(player, new_scan)

-- if they are not holding any item, return
if player.is_cursor_empty() then return end

-- get the item stack of whatever they are holding
stack = player.cursor_ghost or player.cursor_stack

if not stack.valid_for_read then return end
if player.is_cursor_empty() and not player.cursor_ghost then return end

local stack
if player.cursor_ghost then
-- if the cursor ghost is valid, name is the LuaItemPrototype
stack = player.cursor_ghost.name
elseif player.cursor_stack and player.cursor_stack.valid_for_read then
-- if the cursor stack is valid, prototype is the LuaItemPrototype
stack = player.cursor_stack.prototype
end

-- get the prototype, which is "name" for cursor_ghost for whatever reason
stack = prototypes.item[player.cursor_ghost and stack.name.name or stack.name]
if not stack then return end

-- if the item they are holding is not an underground belt or a pipe-to-ground, return
place_result = stack.place_result
Expand Down