pbjs/sparse: fix namespace replacement, include transitive dependencies #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable, we'll just need some more time to review the change and we'll get back to you @imirkin. Thanks for the PR! |
This fixes sparse mode for my use-case. Protos are spread over several files, and may include nested messages/enums from other files. Additionally, this fixes the case where a Type is replaced by a Namespace, e.g. when an enum is used without its containing message type. Fixes protobufjs#1436
|
Is there any progress on this please? @alexander-fenster |
|
Is there any chance this will ever get in? Should I just close it? Rebase it? I can't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes sparse mode for my use-case. Protos are spread over several
files, and may include nested messages/enums from other files.
Additionally, this fixes the case where a Type is replaced by a Namespace,
e.g. when an enum is used without its containing message type.
Fixes #1436