-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typings incorrectly generated with any
#731
Comments
Your change seems to have fixed this issue, but also has introduced a new one. This is the diff (note that a bunch of |
The diff looks good to me. Implements is gone / properties are (documented) on classes because of #723 - but it should still properly typecheck because class instances still satisfy the type. |
Ah, OK. |
Interestingly, this only affects a few protos in my application.
Given the proto:
type Result$Properties
below hasany
properties:Given the proto:
Event$Properties
below hastimestamp?: any;
Given the proto:
Value$Properties
below haslast_updated?: any;
:The text was updated successfully, but these errors were encountered: