Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protoc-gen-nexus): rewrite printer with ts-poet #241

Merged
merged 7 commits into from
Dec 11, 2022
Merged

refactor(protoc-gen-nexus): rewrite printer with ts-poet #241

merged 7 commits into from
Dec 11, 2022

Conversation

izumin5210
Copy link
Member

Continued from #239

@izumin5210 izumin5210 added the refactoring 🎨 Pull requests that have only internal changes label Dec 11, 2022
@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 5ecd725

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@proto-graphql/codegen-core Minor
@proto-graphql/proto-descriptors Minor
protoc-gen-nexus Minor
protoc-gen-pothos Minor
@proto-graphql/e2e Minor
@proto-graphql/protoc-plugin-helpers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3668096565

  • 147 of 149 (98.66%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.9%) to 98.846%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/protoc-gen-nexus/src/dslgen/printers/index.ts 14 16 87.5%
Totals Coverage Status
Change from base Build 3615836244: 2.9%
Covered Lines: 162
Relevant Lines: 164
💛 - Coveralls

@izumin5210 izumin5210 merged commit 84a24f9 into main Dec 11, 2022
@izumin5210 izumin5210 deleted the izumin5210/rewrite-protoc-gen-nexus-with-ts-poet branch December 11, 2022 09:38
@github-actions github-actions bot mentioned this pull request Dec 11, 2022
Merged
@qnighy qnighy mentioned this pull request Jul 4, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring 🎨 Pull requests that have only internal changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izumin5210 @coveralls