closes #1151: delete multiple jobs from sge at once #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zy4
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1159 +/- ##
========================================
Coverage 13.79% 13.79%
========================================
Files 8 8
Lines 29 29
Branches 1 1
========================================
Hits 4 4
Misses 25 25 Continue to review full report at Codecov.
|
- qdel is not necessary on DB sweep - no need to fetch the job on batch delete old jobs (only drawback is that the watchers will need to refresh in order to see it removed)
Co-authored-by: Felix Gabler <felix.gabler98@gmail.com>
vikramalva
approved these changes
Jan 3, 2021
vikramalva
added a commit
that referenced
this pull request
Jan 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the whole JobActor has to be taken apart. Still this might patch #1151
But: The delete.sh is still used in the wrapper script which still makes sense to me @felixgabler , only the deletion from the DatabaseMonitor was changed to a batch-delete as you proposed.