RenderingService.java_bugfixes #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r call with the diamond operator (
…r call with the diamond operator (
…e such as "StringBuilder".
…se to this switch.
…r call with the diamond operator ("<>").
|
That is true i moved the methods to its object. And it's also true that the previous safeguards were the right way to prevent any NPE, but i started to refactor SonarQube-s code smell so i did it now. But anyway thanks for your comment! |
|
But now i dont know why isnt compile. Any idea? |
|
No idea. And I don't have time to debug this at the moment. I am sure you can figure it out, though. |
|
I messed up and i did it not to our fork, but i leave this branch here becouse we need to show that we did some work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the type specification in this constructor call with the diamond operator ("<>")