ci: cancel in-flight runs when a PR is converted to draft - #3033
Draft
goastler wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as https://github.com/prosopo/captcha-private/pull/4113, applied here.
Adds
converted_to_draftto thepull_requesttypes of the nine PR-triggered workflows. Every one of them already hasconcurrency: cancel-in-progress: true, and that is what does the cancelling — a job-levelifcannot stop a run that is already going. Adding the trigger type means a new run is created, claims the group, and evicts the in-flight one; the jobs then skip, so the new run costs nothing.Seven of the nine need no new condition: they already gate on
github.event.pull_request.draft == false, and on aconverted_to_draftevent the PR is draft, so they skip on their own. Two gate on something else and got an explicitgithub.event.action != 'converted_to_draft':changesets.yml(gates on the PR title)dependabot-changeset.yml(gates on the actor)Out of scope:
tag_release.yml(closedonly) andrelease.yml.Not verifiable from a draft PR — to prove it, convert a throwaway non-draft PR to draft while a run is in flight and watch the run get cancelled.