-
Notifications
You must be signed in to change notification settings - Fork 95
[Feature] Vectorized lidar #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 87.47% 88.22% +0.75%
==========================================
Files 82 83 +1
Lines 9507 9688 +181
==========================================
+ Hits 8316 8547 +231
+ Misses 1191 1141 -50 ☔ View full report in Codecov by Sentry. |
|
@Zartris if you wanna review / try it out this shoulf be mega fasttttt |
|
Oh that was quick! Ill take a look today |
|
pollock scenario use_vmas_env(
scenario_name="pollock",
render=False,
save_render=False,
random_action=True,
continuous_actions=False,
n_agents=15,
n_lines=15,
n_boxes=15,
lidar=True,
n_steps=100,
num_envs=32,
)before PR:
after PR:
🚀 |
|
Everything seems to work good. |
continuation of #122
What we vectorize
Let me recap the levels of looping:
And here is what we vectorize:
Benchmarking
pollock scenario
before PR:
M1 cpu: 134.55210709571838s
CUDA: 571.7651047706604s
after PR:
M1 cpu: 22.2061710357666s (0.16x the previous time)
CUDA: 91.27248549461365s (0.15 x the previous time)
benefit will increase in the number of steps and envs
🚀