Wrappers as decorators #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… merge enforce_edges, enforce_centers, carotpy_gridfix, and basemap_gridfix into standardize_2d
… basemap wrappers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #37. Wrappers are now implemented in
axes.Axes, with the succinct syntax e.g.plot = wrapper1(wrapper2(Axes.plot))rather than the more verbose decorator syntax. This is a major improvement, because it means we are no longer messing with__getattribute__. It also means we can begin to apply method-specific behavior in e.g.plot,contourf,pcolormesh, etc. methods, rather than queryingfunc.__name__inside complex wrappers (e.g.cmap_wrapper) to apply method-specific behavior. This is just a starting point.