Add AAAS journals to subplot command #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukelbd, this PR adds the AAAS journal specs to the
proplot.subplots()
command. It also has a few minor fixes:JOURNAL_SPECS
following PEP (https://www.python.org/dev/peps/pep-0008/#constants).subplots()
that was causing certain journal specs to break.pytest
for all journal specs as a template for future testing.This is a great simple example of pytest's power. I created the test then ran pytest and found consistent errors in certain subsets of the dictionary (
TypeError
vs.ValueError
). Once you get pytest implemented into Travis CI, this will run automatically on PRs and then you have no risk of importing broken code. At least broken journal spec code for now.