Skip to content

Refactor legend+colorbar internals, support "queueing" and location-based replacements #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2021
Merged

Refactor legend+colorbar internals, support "queueing" and location-based replacements #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ae1742
Restore+expand mpl behavior by supporting successive legend additions
lukelbd Jul 2, 2021
88dd2c8
Move 'queued' cbar+legend features to methods, clean up internals
lukelbd Jul 3, 2021
da972de
Update changelog
lukelbd Jul 3, 2021
bb61827
Tweak default inset colorbar padding/width
lukelbd Jul 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions WHATSNEW.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,12 @@ ProPlot v0.7.0 (2021-06-30)
Make the ``Browns1`` map the most colorful/vibrant one, just like ``Greens1`` and
``Blues1``; split up the ``RedPurple`` maps into ``Reds`` and ``Purples``; and add
the ``Yellows`` category from the ``Oranges`` maps (:commit:`8be0473f`).
* Rename `abovetop` keyword for moving title/abc labels above or below top panels,
colorbars, and legends to :rcraw:`title.above` (:commit:`9ceacb7b`).
* Reduce matplotlib conflicts by replacing legends drawn in the same location
rather than drawing two legends (:pr:`254`).
* Until centered-row legends become a class, stop returning the ad hoc background patch,
consistent with inaccessible background patches for inset colorbars (:pr:`254`).
* Rename `abovetop` keyword for moving title/abc labels above top panels, colorbars,
and legends to :rcraw:`title.above` (:commit:`9ceacb7b`).
* Rename seldom-used `Figure` argument `fallback_to_cm` to more understandable
`mathtext_fallback` (:pr:`251`).

Expand All @@ -102,6 +106,8 @@ ProPlot v0.7.0 (2021-06-30)
users have a cartopy vs. basemap preference, they probably want to use it globally.
* Add :rcraw:`cartopy.circular` setting for optionally disabling the "circular bounds
on polar projections" feature (:commit:`c9ca0bdd`).
* Add `queue` keyword to `colorbar` and `legend` to support workflow where users
successively add handles to location (:pr:`254`).
* Add `titlebbox` and `abcbbox` as alternatives to `titleborder` and `abcborder`
for "inner" titles and a-b-c labels (:pr:`240`) by `Pratiman Patel`_.
Default behavior uses borders.
Expand Down Expand Up @@ -160,6 +166,8 @@ ProPlot v0.7.0 (2021-06-30)
(:pr:`251`).
* Fix issue where "twin" ("alternate") axes content always hidden beneath "parent"
content due to adding as children (:issue:`223`).
* Fix issue where simple `pandas.DataFrame.plot` calls with ``legend=True`` fail
(:pr:`254`, :issue:`198`).
* Fix issue where cannot set `rc.style = 'default'` (:pr:`240`) by `Pratiman Patel`_.
* Fix issue where `get_legend` returns None even with legends present (:issue:`224`).
* Fix issue where `~xarray.DataArray` string coordinates are not extracted from
Expand Down Expand Up @@ -210,6 +218,8 @@ ProPlot v0.7.0 (2021-06-30)

.. rubric:: Internals

* Significantly refactor `colorbar` and `legend` code to make more manageable and
expand the "queueing" feature beyond wrappers (:pr:`254`).
* Add prefix ``'proplot_'`` to registered axes "projections" (:commit:`be7ef21e`). More
clear and guards against conflicts with external packages and other mpl versions.

Expand Down
Loading