Move cleanup logic into Makefile #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #308 brought up the issue that the `clean` command of rebar3 had a Unix-based script as a `post_hook` that could not be run on Windows. Rather that adopting #308 and run the risk of leaving out some OSs out, move all cleanup logic, including calling cleanup scripts, to the Makefile instead. This should avoid `rebar3 clean` crashing on Windows. While at it, move the `rebar3 clean` call from the `distclean` to the `clean` target of Makefile, which seems more standard (and kosher). Closes #308
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 85.35% 85.46% +0.10%
==========================================
Files 14 14
Lines 4590 4590
==========================================
+ Hits 3918 3923 +5
+ Misses 672 667 -5 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #308 brought up the issue that the
cleancommand of rebar3 had a Unix-based script as apost_hookthat could not be run on Windows. Rather that adopting #308 and run the risk of leaving out some OSes, move all cleanup logic, including calling cleanup scripts, to the Makefile instead. This should avoidrebar3 cleancrashing on Windows.While at it, move the
rebar3 cleancall from thedistcleanto thecleantarget of Makefile, which seems more standard.Closes #308