Use covertool as a project_plugin, rather than plugin#284
Closed
michalmuskala wants to merge 1 commit intoproper-testing:masterfrom
Closed
Use covertool as a project_plugin, rather than plugin#284michalmuskala wants to merge 1 commit intoproper-testing:masterfrom
michalmuskala wants to merge 1 commit intoproper-testing:masterfrom
Conversation
This was resulting in `covertool` being pulled-in as a dependency needlessly in downstream projects in some situations. Using it as a `project_plugin` is advised by `covertool` [itself](https://github.com/covertool/covertool#rebar3). More on plugins vs project plugins: https://rebar3.readme.io/docs/using-available-plugins
Collaborator
|
Thanks for your contribution and your interest in PropEr but tere is a similar PR (#283) that beat this one in a race.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was resulting in
covertoolbeing pulled-in as a dependency needlessly in downstream projects in some situations.Using it as a
project_pluginis advised bycovertoolitself.More on plugins vs project plugins: https://rebar3.readme.io/docs/using-available-plugins