Skip to content

feat: Add ShibaswapV2 executor implementation #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
VAIBHAVJINDAL3012 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Add ShibaswapV2 executor implementation #284

VAIBHAVJINDAL3012 wants to merge 3 commits into from

Conversation

@VAIBHAVJINDAL3012
Copy link

@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 commented Oct 24, 2025

  • Add ShibaswapV2Executor contract (UniswapV3 clone)

    • Implements swap, callback, and verification functions
    • Uses same price ratio limits as UniswapV3
    • Factory and init code hash verification

  • Add comprehensive test suite (ShibaswapV2.t.sol)

    • Unit tests for data decoding
    • Error handling tests
    • Integration test scaffolding (ready for real addresses)

  • Update Rust encoding layer

    • Add shibaswap_v2 to swap encoder builder
    • Register in IN_TRANSFER_REQUIRED_PROTOCOLS
    • Reuses UniswapV3SwapEncoder

  • Update configuration files

    • Add executor addresses for mainnet and testnet
    • Add test constants (factory, init hash, pool addresses)

feat: Add ShibaswapV2 executor implementation
472acbf 
- Add ShibaswapV2Executor contract (UniswapV3 clone)
  - Implements swap, callback, and verification functions
  - Uses same price ratio limits as UniswapV3
  - Factory and init code hash verification

- Add comprehensive test suite (ShibaswapV2.t.sol)
  - Unit tests for data decoding
  - Error handling tests
  - Integration test scaffolding (ready for real addresses)

- Update Rust encoding layer
  - Add shibaswap_v2 to swap encoder builder
  - Register in IN_TRANSFER_REQUIRED_PROTOCOLS
  - Reuses UniswapV3SwapEncoder

- Update configuration files
  - Add executor addresses for mainnet and testnet
  - Add test constants (factory, init hash, pool addresses)

Ready for deployment once real Shibaswap V2 addresses are provided.
@github-project-automation github-project-automation bot moved this to Todo in Tycho Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Tycho
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@VAIBHAVJINDAL3012