Feature/serializer

composer.json

@@ -26,7 +26,7 @@
     "prefer-stable": true,
     "require": {
         "php": "^7.1",
-        "prooph/snapshot-store" : "^1.0",
+        "prooph/snapshot-store" : "^1.1"
         "mongodb/mongodb": "^1.1.0"
     },
     "require-dev": {

docs/interop_factories.md

@@ -38,6 +38,7 @@ Sample configuration:
                     'wtimeout' => 0, // How long to wait (in milliseconds) for secondaries before failing.
                     'journal' => false, // Wait until mongod has applied the write to the journal.
                 ],
+                'serializer' => 'My\Serializer' //<-- optional, service name of a custom serializer
             ],
         ],
     ],

src/Container/MongoDbSnapshotStoreFactory.php

@@ -18,7 +18,9 @@
 use Interop\Config\RequiresMandatoryOptions;
 use MongoDB\Driver\ReadConcern;
 use MongoDB\Driver\WriteConcern;
+use Prooph\SnapshotStore\CallbackSerializer;
 use Prooph\SnapshotStore\MongoDb\MongoDbSnapshotStore;
+use Prooph\SnapshotStore\Serializer;
 use Psr\Container\ContainerInterface;
 
 class MongoDbSnapshotStoreFactory implements ProvidesDefaultOptions, RequiresConfigId, RequiresMandatoryOptions
@@ -71,13 +73,16 @@ public function __invoke(ContainerInterface $container): MongoDbSnapshotStore
             $config['write_concern']['journal']
         );
 
+        $serializer = $config['serializer'] instanceof Serializer ? $config['serializer'] : $container->get($config['serializer']);
+
         return new MongoDbSnapshotStore(
             $client,
             $config['db_name'],
             $config['snapshot_grid_fs_map'],
             $config['default_snapshot_grid_fs_name'],
             $readConcern,
-            $writeConcern
+            $writeConcern,
+            $serializer
         );
     }
 
@@ -102,6 +107,7 @@ public function defaultOptions(): iterable
                 'wtimeout' => 0, // How long to wait (in milliseconds) for secondaries before failing.
                 'journal' => false, // Wait until mongod has applied the write to the journal.
             ],
+            'serializer' => new CallbackSerializer(null, null),
         ];
     }
 

src/MongoDbSnapshotStore.php

@@ -18,6 +18,8 @@
 use MongoDB\Driver\ReadConcern;
 use MongoDB\Driver\WriteConcern;
 use MongoDB\GridFS\Exception\FileNotFoundException;
+use Prooph\SnapshotStore\CallbackSerializer;
+use Prooph\SnapshotStore\Serializer;
 use Prooph\SnapshotStore\Snapshot;
 use Prooph\SnapshotStore\SnapshotStore;
 
@@ -55,13 +57,19 @@ final class MongoDbSnapshotStore implements SnapshotStore
      */
     private $writeConcern;
 
+    /**
+     * @var Serializer
+     */
+    private $serializer;
+
     public function __construct(
         Client $client,
         string $dbName,
         array $snapshotGridFsMap = [],
         string $defaultSnapshotGridFsName = 'snapshots',
         ReadConcern $readConcern = null,
-        WriteConcern $writeConcern = null
+        WriteConcern $writeConcern = null,
+        Serializer $serializer = null
     ) {
         if (null === $readConcern) {
             $readConcern = new ReadConcern(ReadConcern::LOCAL);
@@ -77,6 +85,7 @@ public function __construct(
         $this->defaultSnapshotGridFsName = $defaultSnapshotGridFsName;
         $this->readConcern = $readConcern;
         $this->writeConcern = $writeConcern;
+        $this->serializer = $serializer ?: new CallbackSerializer(null, null);
     }
 
     public function get(string $aggregateType, string $aggregateId): ?Snapshot
@@ -98,7 +107,7 @@ public function get(string $aggregateType, string $aggregateId): ?Snapshot
 
         $destination = $this->createStream();
         stream_copy_to_stream($stream, $destination);
-        $aggregateRoot = unserialize(stream_get_contents($destination, -1, 0));
+        $aggregateRoot = $this->serializer->unserialize(stream_get_contents($destination, -1, 0));
 
         return new Snapshot(
             $aggregateType,
@@ -129,7 +138,7 @@ public function save(Snapshot ...$snapshots): void
 
             $bucket->uploadFromStream(
                 $aggregateId,
-                $this->createStream(serialize($snapshot->aggregateRoot())),
+                $this->createStream($this->serializer->serialize($snapshot->aggregateRoot())),
                 [
                     '_id' => $aggregateId,
                     'metadata' => [

tests/Container/MongoDbSnapshotStoreFactoryTest.php

@@ -13,6 +13,7 @@
 namespace ProophTest\SnapshotStore\MongoDb\Container;
 
 use PHPUnit\Framework\TestCase;
+use Prooph\SnapshotStore\CallbackSerializer;
 use Prooph\SnapshotStore\MongoDb\Container\MongoDbSnapshotStoreFactory;
 use Prooph\SnapshotStore\MongoDb\MongoDbSnapshotStore;
 use ProophTest\SnapshotStore\MongoDb\TestUtil;
@@ -53,4 +54,29 @@ public function it_throws_exception_when_invalid_container_given(): void
         $eventStoreName = 'custom';
         MongoDbSnapshotStoreFactory::$eventStoreName('invalid container');
     }
+
+    /**
+     * @test
+     */
+    public function it_gets_serializer_from_container_when_not_instanceof_serializer(): void
+    {
+        $config['prooph']['mongodb_snapshot_store']['default'] = [
+            'mongo_client_service' => 'my_connection',
+            'db_name' => 'foo',
+            'serializer' => 'serializer_servicename',
+        ];
+
+        $client = TestUtil::getClient();
+
+        $container = $this->prophesize(ContainerInterface::class);
+
+        $container->get('my_connection')->willReturn($client)->shouldBeCalled();
+        $container->get('config')->willReturn($config)->shouldBeCalled();
+        $container->get('serializer_servicename')->willReturn(new CallbackSerializer(function() {}, function() {}))->shouldBeCalled();
+
+        $factory = new MongoDbSnapshotStoreFactory();
+        $snapshotStore = $factory($container->reveal());
+
+        $this->assertInstanceOf(MongoDbSnapshotStore::class, $snapshotStore);
+    }
 }