Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not fully sold that we're allowing for the SYSTEM message to be passed to OpenAI during RAG. #24

Closed
ryaneggz opened this issue May 16, 2024 · 1 comment
Closed

Not fully sold that we're allowing for the SYSTEM message to be passed to OpenAI during RAG. #24

ryaneggz opened this issue May 16, 2024 · 1 comment

Comments

@ryaneggz
Copy link
Contributor

It does not throw an error but believe the code below should have the system message passed to it or have this be the default and then also be able to accept a value from frontend as override.

image
@ryaneggz
Copy link
Contributor Author

This should be fine now esspecially for OpenAI

ryaneggz added a commit that referenced this issue Sep 28, 2024
@ryaneggz
Merge branch 'bugfix/24-fix-retrieval-agent' into 'development'
575c763 
FROM bugfix/24-fix-retrieval-agent INTO development

Closes #24

See merge request prompt-engineers/v2/llm-server!16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryaneggz