Skip to content

Add failing tests for issue #392: pdd change KeyError at Step 5 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Serhan-Asad wants to merge 3 commits into from
Closed

Add failing tests for issue #392: pdd change KeyError at Step 5 #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cd774b
Add failing E2E tests for issue #392 (pdd change KeyError at Step 5)
Serhan-Asad Jan 29, 2026
4d0cce0
Improve bug detection tests for issue #392
Serhan-Asad Jan 29, 2026
10189c9
fix: pdd change fails at Step 5 with 'Context missing key for step 5:…
Serhan-Asad Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added new_file.txt
View file
Open in desktop
Empty file.
12 changes: 12 additions & 0 deletions pdd/agentic_change_orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
DEFAULT_MAX_RETRIES,
)
from pdd.load_prompt_template import load_prompt_template
from pdd.preprocess import preprocess
from pdd.sync_order import (
build_dependency_graph,
topological_sort,
Expand Down Expand Up @@ -594,6 +595,17 @@ def run_agentic_change_orchestrator(
if not prompt_template:
return False, f"Missing prompt template: {template_name}", total_cost, model_used, []

# Preprocess to expand <include> tags and escape curly braces
# This prevents KeyError when templates or included files contain JSON with braces
# See: Issue #392, compare with agentic_architecture_orchestrator.py:299-302
exclude_keys = list(context.keys())
prompt_template = preprocess(
prompt_template,
recursive=True,
double_curly_brackets=True,
exclude_keys=exclude_keys
)

try:
formatted_prompt = prompt_template.format(**context)
except KeyError as e:
Expand Down
Loading