Add failing tests for #419: Unpushed commits in early exit

[Serhan-Asad]

Summary

Adds comprehensive failing tests that detect the bug reported in #419 where commits created by LLM agents during Step 1 of the agentic E2E fix workflow are not pushed to the remote repository when the workflow exits early at Step 2.

Test Files

• Unit test: tests/test_e2e_issue_419_unpushed_commits.py

  • Tests the _commit_and_push() function directly
  • Contains 3 test cases covering the bug scenario and edge cases
  • 1 test FAILS (the bug), 2 tests PASS (existing functionality)

• E2E test: tests/test_e2e_issue_419_cli_unpushed_commits.py

  • Tests the full pdd fix CLI workflow from user perspective
  • Simulates real git operations with a remote repository
  • Verifies commits are pushed after early exit at Step 2
  • Currently FAILS, demonstrating the bug

What This PR Contains

• Failing unit test that isolates and reproduces the bug in _commit_and_push()
• Failing E2E test that verifies the bug at the full workflow integration level
• Tests use real git operations (not mocked) to verify actual push behavior
• Tests are verified to fail on current code and will pass once the bug is fixed
• Comprehensive test coverage following project conventions

Root Cause

The _commit_and_push() function at lines 237-238 in pdd/agentic_e2e_fix_orchestrator.py returns early with "No changes to commit" without executing git push when the working tree is clean. The function uses _get_file_hashes() which only detects uncommitted files via git diff --name-only HEAD, missing commits already created by LLM agents during Step 1 of the workflow.

Why it fails:

1. initial_file_hashes captured before workflow = {} (no uncommitted files)
2. LLM agent modifies files and creates commit during Step 1
3. Workflow exits early at Step 2 (ALL_TESTS_PASS detected)
4. _commit_and_push() is called, but current_hashes = {} (working tree is clean)
5. Function returns "No changes to commit" without executing git push
6. Commits remain unpushed despite workflow reporting success

Next Steps

1. Implement the fix at pdd/agentic_e2e_fix_orchestrator.py:237-238
2. Verify the unit test passes after fix
3. Verify the E2E test passes after fix
4. Run full test suite to check for regressions
5. Mark PR as ready for review

Fixes #419

---

Generated by PDD agentic bug workflow - Step 10

[Copilot]

Pull request overview

This PR adds comprehensive test coverage for issue #419, which identifies a bug where commits created by LLM agents during Step 1 of the agentic E2E fix workflow are not pushed to the remote repository when the workflow exits early at Step 2.

Changes:

• Adds unit tests that directly test the _commit_and_push() function to verify it handles unpushed commits
• Adds E2E tests that simulate the full CLI workflow to verify commits are pushed after early exit
• Includes a proposed fix to _commit_and_push() that checks for and pushes unpushed commits even when the working tree is clean

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
tests/test_e2e_issue_419_unpushed_commits.py	Unit tests for _commit_and_push() covering the bug scenario and edge cases
tests/test_e2e_issue_419_cli_unpushed_commits.py	E2E CLI tests simulating the full orchestrator workflow with mocked LLM calls
pdd/agentic_e2e_fix_orchestrator.py	Proposed fix that checks for unpushed commits before returning early

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.