Skip to content

Support various cursor shapes for more input modes #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

Support various cursor shapes for more input modes #1900

merged 1 commit into from
Sep 25, 2024

Conversation

@Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Jul 29, 2024 •
edited
Loading

Related: #192

@jonathanslenders jonathanslenders merged commit 728983b into prompt-toolkit:master Sep 25, 2024
@jonathanslenders
Copy link
Member

Thanks!

jonathanslenders added a commit that referenced this pull request Sep 25, 2024
@jonathanslenders
Fixup for previous cursorshapes commit (#1900).
c84d874
@jonathanslenders
Copy link
Member

Two comments here:

  • There was a bug in this PR that I fixed here: Fixup for previous cursorshapes commit (#1900). #1920
  • Displaying a "beam" as a cursor for INSERT_MULTIPLE does not work currently, because we can't display multiple cursors. So it renders instead by coloring the background of these cells.

jonathanslenders added a commit that referenced this pull request Sep 25, 2024
@jonathanslenders
Fixup for previous cursorshapes commit (#1900). (#1920)
ae1d635
@Freed-Wu Freed-Wu deleted the cursor branch September 25, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Freed-Wu @jonathanslenders