Use singleton object for Float x/ycursor#183
Use singleton object for Float x/ycursor#183Carreau wants to merge 1 commit intoprompt-toolkit:masterfrom
Conversation
Temptation to start implementing prompt-toolkit#182
|
Hi @Carreau, Thanks a lot for the issue and the work on the pull request! My thoughts:
Possibly a better approach is to rewrite the For this, I also don't mind to be backwards-incompatible (it's mostly used internally), but I prefer to do it correctly. Currently I'm still abroad for work with few spare time, but I will think about this. It's definitely interesting! Jonathan |
Yeah, that was just an example to see that
I'm still wrapping my head around the different case here. Especially xcusrsor and ycursor are hints for positioning. I'm trying to find the correct abstraction. To simplify the interface. I'm also pretty busy with IPython these days, I was mostly trying to change my mind a bit, but will try to work a bit on that and understand more of the code. |
20c1117 to
f8e7255
Compare
ab05f28 to
c7e7160
Compare
17f7a8a to
7bd0e12
Compare
Attempt to start implementing #182
I'm not familiar with the codebase so it might not be he right way to do that,
I suppose the all logic here could be simplified and keep backward compat with
(x|y)cursorScreenshot with this as a completer:
(note, my goal is to have a completer like Fish which is a
cursor.y+1but the all width of terminal in the end, but not really a hsplit)