Update exemplar docs based on changes to exemplar storage configuration #9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
|
|
||
| Note that exemplar storage is still considered experimental and must be enabled via `--enable-feature=exemplar-storage`. | ||
|
|
||
| ```yaml |
There was a problem hiding this comment.
There should be a closing ``` after the following documentation.
docs/configuration/configuration.md
Outdated
Comment on lines
2852
to
2853
| # Configures the maximum size of the circular buffer used to store exemplars for all series. Resizable during runtime. | ||
| [ max_exemplars: <int> | default = 100000 ] |
There was a problem hiding this comment.
No indent is needed here.
Suggested change
| # Configures the maximum size of the circular buffer used to store exemplars for all series. Resizable during runtime. | |
| [ max_exemplars: <int> | default = 100000 ] | |
| # Configures the maximum size of the circular buffer used to store exemplars for all series. Resizable during runtime. | |
| [ max_exemplars: <int> | default = 100000 ] |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LeviHarrison pointed out that we hadn't updated the docs based on the changes from #8974
@roidelapluie not sure how we go about backporting docs into the right releases. Releases from 2.29 forward should have the docs changes from this PR (https://github.com/prometheus/prometheus/releases/tag/v2.29.0)
Signed-off-by: Callum Styan callumstyan@gmail.com