nvme: Parse NVMe namespace details #765
Merged
Merged
Conversation
ShashwatHiregoudar
changed the title
ShashwatHiregoudar
changed the title
discordianfish
approved these changes
Nov 24, 2025
ShashwatHiregoudar
changed the title
Contributor
Author
|
@SuperQ, please help review/approve this PR |
Contributor
Author
|
Hi @SuperQ , just checking in to see if there's anything else you need from my side to move this forward. |
Contributor
Author
|
++ @pgier |
SuperQ
requested changes
Feb 25, 2026
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
Seems mostly fine, but small performance request.
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
ShashwatHiregoudar
force-pushed
the
nvme_namespaces
branch
from
249d8df to
e7e222d
Compare
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
SuperQ
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to append an array of namespaces to the NVMe device.
This change was requested by @discordianfish in another PR-3360. To move the parsing namespace details from node_exporter to procfs.