feat(blockdevice): added sysblockdevicesize method and test #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2024
|
fixed DCO and tests with this new PR cc @dswarbrick |
|
Hi @discordianfish, would it be possible to get your review on this PR? Thanks. |
discordianfish
approved these changes
Sep 22, 2024
fs185143
force-pushed
the
block-device-size
branch
from
0ad8eb3
to
c4644b4
Compare
Add interfaces to read the SELinux AVC runtime statistics from /sys/fs/selinux/avc/cache_stats and /sys/fs/selinux/avc/hash_stats. Refactored from prometheus/node_exporter#2418 Signed-off-by: Christian Göttsche <cgzones@googlemail.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: fs185143 <fs185143@ncr.com>
The NSpids field uses a tab (\t) to separate the list of PIDs. The procfs parser should split on \t, rather than space. This was not caught because the test fixtures themselves used the space character. The patch updates the parser, the fixtures, and adds an explicit test for NSpids. Signed-off-by: Timur Alperovich <timur.alperovich@databricks.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.20.0 to 0.21.0. - [Commits](golang/sys@v0.20.0...v0.21.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.21.0 to 0.22.0. - [Commits](golang/sys@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: fs185143 <fs185143@ncr.com>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.22.0 to 0.24.0. - [Commits](golang/sys@v0.22.0...v0.24.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.7.0 to 0.8.0. - [Commits](golang/sync@v0.7.0...v0.8.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Adds function to return disk stats from: * /sys/block/<disk>/device/ioerr_cnt: number of SCSI commands that completed with an error * /sys/block/<disk>/device/iodone_cnt: number of completed or rejected SCSI commands Add function to return stats for ext4 filesystem * /sys/fs/ext4/<partition>/errors_count: number of ext4 errors * /sys/fs/ext4/<partition>/warning_count: number of ext4 warning log messages * /sys/fs/ext4/<partition>/msg_count: number of other ext4 log messages Signed-off-by: Muhammad Shahzeb <mhmdshahzeb1993@gmail.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: fs185143 <fs185143@ncr.com>
Signed-off-by: fs185143 <fs185143@ncr.com>
fs185143
force-pushed
the
block-device-size
branch
from
c4644b4
to
efdaa11
Compare
Signed-off-by: Finn Snape <145353420+fs185143@users.noreply.github.com>
dswarbrick
approved these changes
Oct 2, 2024
|
@discordianfish mind taking another look at this please? thanks 😄 |
discordianfish
approved these changes
Oct 30, 2024
|
@discordianfish thanks :) didn't seem to get merged automatically? I merged master in in case that was the issue, but now says a workflow is awaiting approval. |
|
@SuperQ needs to review this first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In part to support prometheus/node_exporter#3068, I have added a new method that retrieves the value of
/sys/block/<device>/size