Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: syscall.Statfs_t object doesn't have a Type field on Windows #528

Merged
merged 1 commit into from
May 28, 2023
Merged

fs: syscall.Statfs_t object doesn't have a Type field on Windows #528

merged 1 commit into from
May 28, 2023

Conversation

adrianosela
Copy link
Contributor

fs: syscall.Statfs_t object doesn't have a Type field on Windows

Fixes build for GOOS=windows (#527)

This PR extends the solution from #523 to include windows in the list of OSes for which the syscall.Statfs_t object does not have a Type field

Testing:

Before:

✔ ~/go/src/github.com/adrianosela/procfs [master|✔]
11:22 $ GOOS=windows GOARCH=amd64 go build
# github.com/prometheus/procfs
./fs_statfs_type.go:25:18: undefined: syscall.Statfs_t
./fs_statfs_type.go:26:17: undefined: syscall.Statfs

After:

✔ ~/go/src/github.com/adrianosela/procfs [master|✔]
11:24 $ GOOS=windows GOARCH=amd64 go build
✔ ~/go/src/github.com/adrianosela/procfs [master|✔]

@adrianosela
fs: Statfs_t{} doesn't have a Type field on Windows
85cd2e7 
Signed-off-by: Adriano Sela Aviles <adriano.selaviles@gmail.com>
SuperQ
SuperQ approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@SuperQ SuperQ merged commit 5d2473f into prometheus:master May 28, 2023
SuperQ pushed a commit that referenced this pull request May 28, 2023
@adrianosela @SuperQ
fs: Statfs_t{} doesn't have a Type field on Windows (#528)
57895a2 
Signed-off-by: Adriano Sela Aviles <adriano.selaviles@gmail.com>
SuperQ added a commit that referenced this pull request May 28, 2023
@SuperQ @adrianosela
fs: Statfs_t{} doesn't have a Type field on Windows (#528) (#529)
332e865 
Signed-off-by: Adriano Sela Aviles <adriano.selaviles@gmail.com>
Co-authored-by: Adriano Sela Aviles <adriano.selaviles@gmail.com>
@adrianosela
Copy link
Contributor Author

Cross posting from: #529

Hey @SuperQ , would be good to go over the list here https://github.com/golang/go/blob/master/src/go/build/syslist.go and deal with all of the OSes.... there's a list of unix-like OSses there too, so maybe worth just going off of that?

jritter pushed a commit to jritter/procfs that referenced this pull request Jul 15, 2024
@adrianosela @jritter
fs: Statfs_t{} doesn't have a Type field on Windows (prometheus#528)
cb5ff6b 
Signed-off-by: Adriano Sela Aviles <adriano.selaviles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianosela @SuperQ