fix zoneinfo name parsing #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add aditional test coverage for Normal, Movable and Devize zones Signed-off-by: binjip978 <binjip978@gmail.com>
|
fixes #386 |
|
Thanks! Not sure what the rational was for resetting the zone field, so not sure that isn't breaking anything else..? |
|
Me either, but empty zone name in current version of the test does not look right. |
I can't even remember writing that :) It's just a novice mistake i guess. |
SuperQ
approved these changes
Jul 21, 2021
knweiss
reviewed
Jul 30, 2021
| data, err := fs.Zoneinfo() | ||
| if err != nil { | ||
| t.Fatalf("failed to parse zoneinfo: %v", err) | ||
| } | ||
| if len(data) != 5 { | ||
| t.Fatal("failed to get all all node info") |
There was a problem hiding this comment.
"all all"
Otherwise: LGTM.
(I've tested node-exporter 1.2.1 from the master branch on the system where I initially noticed the bug.)
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
Add aditional test coverage for Normal, Movable and Devize zones Signed-off-by: binjip978 <binjip978@gmail.com>
jritter
pushed a commit
to jritter/procfs
that referenced
this pull request
Jul 15, 2024
Add aditional test coverage for Normal, Movable and Devize zones Signed-off-by: binjip978 <binjip978@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aditional test coverage for Normal, Movable and Devize zones
Signed-off-by: binjip978 binjip978@gmail.com