MDStat parsing enrichment #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trearcul
force-pushed
the
mdstat-enrichment
branch
from
16a3682
to
a9f5948
Compare
Added parsing of - RAID personality - Sync/check percent and remaining minutes - Assigned partitions/devices Expected test data updated accordingly Signed-off-by: trearcul <pavel.vondrak@hotmail.cz>
trearcul
force-pushed
the
mdstat-enrichment
branch
from
987b580
to
3c989a7
Compare
|
I strongly suggest that future enhancements to mdraid stats use the sysfs entries, rather than add any more parsing of /proc/mdstat. The sysfs interface is designed to be machine-readable, whereas /proc/mdstat is designed to be human-readable. This results in a lot of regexes, which may not stand the test of time if the format of /proc/mdstat is changed or enhanced (unlikely). See also prometheus/node_exporter#1085 |
|
This looks like it needs a rebase. |
|
This appears abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enriches data parsing of MD devices from
/proc/mdstat. All the additional data could be useful for enhancing prometheus exporters (e.g., NodeExporter) as a next step.Added parsing of: