Add netdev collector for darwin #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobie
approved these changes
Dec 29, 2016
| return netDev, nil | ||
| } | ||
|
|
||
| func convertFreeBSDCPUTime(counter uint64) string { |
There was a problem hiding this comment.
Good question. I've copied it over from the freebsd one. I've changed it to use FormatUint directly.
There was a problem hiding this comment.
So this method can be deleted then?
There was a problem hiding this comment.
Already did that, looks like the commit is outdated.
discordianfish
force-pushed
the
fish-add-netdev-darwin
branch
from
e38d1c8
to
f6f1ba1
Compare
Same as for openbsd, this is just slightly adjusted from freebsd variant.
discordianfish
force-pushed
the
fish-add-netdev-darwin
branch
from
f6f1ba1
to
3c47ef8
Compare
SuperQ
approved these changes
Jan 3, 2017
Merged
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Our company internal Prometheus exporter uses the procfs library and needs to read `/proc/cmdline`. Since `fs.proc.Path` cannot be accessed from outside, add `CmdLine` to procfs to read `/proc/cmdline`. Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as for openbsd, this is just slightly adjusted from freebsd
variant.
I'd like to merge all those and only have the bare minimum in platform specific files but for now I think adding it as this is fine. Will help with the refactoring later.