fix(collector/pcidevice): Add nil checks to prevent panic #3421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pcidevice collector panics with a "nil pointer dereference" error
on some systems. This occurs when a PCI device lacks certain attributes
in sysfs, such as 'current_link_speed' or 'current_link_width'.
The collector's Update method attempted to dereference these pointers
without verifying if they were nil, leading to a crash.
This commit introduces checks to verify that the link speed and width
pointers are not nil before they are dereferenced. If an attribute is
missing for a device, its corresponding metric will now be reported as 0,
making the collector more robust and preventing node_exporter from
crashing.