improving nvme collector [duplicate]#3330
Closed
ShashwatHiregoudar wants to merge 25 commits into
Closed
Conversation
SuperQ
requested changes
May 9, 2025
Comment on lines
+117
to
+118
| devicePath := filepath.Join(*sysPath, "class/nvme", device.Name) | ||
| if cntlid, err := readUintFromFile(filepath.Join(devicePath, "cntlid")) |
Member
There was a problem hiding this comment.
Reading data from sys/proc needs to happen in the procfs library.
Contributor
Author
There was a problem hiding this comment.
Cntlid isn't exposed from the library,
Created a PR in the procfs library to do the same
prometheus/procfs#731
Improvement of the NVMe collector in node-exporter, to include the below-mentioned NVMe namespace-specific parameters NUSE NCAP NSZE LBA Size ANA State Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
There is a bug in darwin kernel since macOS Ventura 13.2.1, which results in interface i/o bytes values to be truncated at 4GiB. This change uses a workaround to collect the same metrics, taking advantage of another bug. fixes #3333 Signed-off-by: Siavash Safi <git@hosted.run> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Bumps [github.com/mdlayher/wifi](https://github.com/mdlayher/wifi) from 0.3.1 to 0.5.0. - [Release notes](https://github.com/mdlayher/wifi/releases) - [Commits](mdlayher/wifi@v0.3.1...v0.5.0) --- updated-dependencies: - dependency-name: github.com/mdlayher/wifi dependency-version: 0.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
The ethtool_linux looks for ethtool stats with their sanitized name which might be different from the name provisioned by ethtool. This caused node-exporter to return a 0-value for sanitized metrics. This patch works-around the missing key by copying ethtool stats to another map under their sanitized name. Signed-off-by: Guillaume Espanel <guillaume.espanel@ovhcloud.com> Co-authored-by: Guillaume Espanel <guillaume.espanel@ovhcloud.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.30.0 to 0.32.0. - [Commits](golang/sys@v0.30.0...v0.32.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-version: 0.32.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Nabil <nabilcharaf37@gmail.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
While having overlap with NetAdpter metrics, the metrics are slightly different so need to be exposed as well. Signed-off-by: Johannes Ziemke <github@5pi.de> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.62.0 to 0.63.0. - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md) - [Commits](prometheus/common@v0.62.0...v0.63.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-version: 0.63.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Michael Fuller <mfuller@lambdal.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Manuel Rüger <manuel@rueg.eu> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: mengxun <mengxun1122@163.com> Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
Signed-off-by: Shashwat Hiregoudar <shashwat.h@flipkart.com>
ShashwatHiregoudar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement of the NVMe collector in node-exporter, to include the below-mentioned NVMe namespace-specific parameters NUSE
NCAP
NSZE
LBA Size
ANA State