Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collector/cpu: Support CPU online status #3032

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rexagod
Copy link
Contributor

@rexagod rexagod commented May 30, 2024

Blocked by: prometheus/procfs#644.

Fixes: #873

@rexagod rexagod force-pushed the 873 branch 4 times, most recently from eaed8e7 to 10175d6 Compare June 21, 2024 10:07
rexagod added a commit to rexagod/node_exporter that referenced this pull request Jun 21, 2024
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/node_exporter that referenced this pull request Jun 21, 2024
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/node_exporter that referenced this pull request Jun 21, 2024
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/node_exporter that referenced this pull request Jun 21, 2024
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/node_exporter that referenced this pull request Jul 2, 2024
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod added a commit to rexagod/node_exporter that referenced this pull request Jul 2, 2024
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
SuperQ pushed a commit that referenced this pull request Jul 10, 2024
Needed-for: #3032

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ
Copy link
Member

SuperQ commented Jul 14, 2024

This needs a rebase.

@rexagod rexagod force-pushed the 873 branch 3 times, most recently from 6ae6041 to a20efb6 Compare July 15, 2024 11:36
@rexagod
Copy link
Contributor Author

rexagod commented Aug 13, 2024

(ping 😅)

@discordianfish
Copy link
Member

@rexagod sorry but this needs rebase again
@SuperQ lets make sure we get this in once @rexagod rebased it

@rexagod
Copy link
Contributor Author

rexagod commented Sep 22, 2024

Rebasing on #3131.

Sync dependencies and log using the machinery introduced in prometheus#3097.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Blocked by: prometheus/procfs#644.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Contributor Author

rexagod commented Oct 19, 2024

Good for reviews.

v-zhuravlev pushed a commit to grafana/node_exporter that referenced this pull request Nov 1, 2024
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: offline CPU handling
3 participants