Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build #2625

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Update build #2625

merged 1 commit into from
Mar 8, 2023

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Mar 7, 2023 •
edited
Loading

  • Update Go to 1.20
  • Update golangci-lint.
  • Update CI orb.
  • Fix staticcheck issue in perf collector.

@SuperQ SuperQ requested a review from discordianfish March 7, 2023 16:48
@SuperQ
Copy link
Member Author

SuperQ commented Mar 7, 2023

So, the perf collector has some weird use of pointers that I think is confusing the staticcheck tests.

@SuperQ
Update build
3691cb9 
* Update Go to 1.20
* Update golangci-lint.
* Update CI orb.
* Fix staticcheck issue in perf collector.

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ force-pushed the superq/update_build branch from 661e2dc to 3691cb9 Compare March 8, 2023 10:16
@SuperQ SuperQ requested a review from roidelapluie March 8, 2023 10:17
@SuperQ SuperQ merged commit 8daf3e7 into master Mar 8, 2023
@SuperQ SuperQ deleted the superq/update_build branch March 8, 2023 15:26
@SuperQ SuperQ mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roidelapluie roidelapluie roidelapluie approved these changes

@discordianfish discordianfish Awaiting requested review from discordianfish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperQ @roidelapluie