meminfo: Fix the size mismatch in the swapTotal check mib for BSD. #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyber
force-pushed
the
bsd-meminfo-collector-size-fix
branch
from
041ad0a to
d35ded0
Compare
|
Good find, thanks for the fix. Would you please add a |
Signed-off-by: David O'Rourke <david.orourke@gmail.com>
phyber
force-pushed
the
bsd-meminfo-collector-size-fix
branch
from
d35ded0 to
b9d47c6
Compare
|
Done! 👍 |
SuperQ
pushed a commit
that referenced
this pull request
Jun 4, 2019
…1345) Signed-off-by: David O'Rourke <david.orourke@gmail.com>
Merged
SuperQ
pushed a commit
that referenced
this pull request
Jun 4, 2019
…1345) Signed-off-by: David O'Rourke <david.orourke@gmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
…rometheus#1345) Signed-off-by: David O'Rourke <david.orourke@gmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
…rometheus#1345) Signed-off-by: David O'Rourke <david.orourke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1344
The size of the
sysctlcall during the MIB name check was wrong, causing this check to fail on FreeBSD (and probably on DragonFly too, failure was expected there, but probably not this failure).This PR fixes things so that the size of the sysctl call matches the documented
dataTypeofbsdSysctlTypeUint64from the array of sysctls.