-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to add label for mount point to mountstats #2097
Comments
Yeah agree, this should have a mountpoint label. |
Issue: prometheus#2097 Signed-off-by: John Gauthier <jgauth@users.noreply.github.com>
Did we have something like this previously, but removed it to avoid duplicate metrics? |
Looks like it: 5a6db5c Can we include the mountpoint label, while also skipping duplicates? |
Yea, that seems reasonable. Pick first one, ignore the rest, is that good enough? |
I would like to work on this, unless there is already someone actively working on it |
By bizarre synchronicity I was actually working on a patch for this before I was aware of this issue. Hopefully the PR above will either resolve this or at least prove helpful. |
I'll take a look at #2102 and try to get a PR out this week |
@dsnt02518 Since you have #2676 already open, I'll leave this to you |
Currently the labels for NFS metrics from mountstats are
"export", "protocol", "mountaddr"
I'm requesting that another label be added, the mountpoint on the NFS client.
For example if
/proc/self/mountstats
had the following device info:device myhostname.com:/exports/example mounted on /auto/example with fstype nfs statvers=1.1
I'd like to have a label:
mountpoint: /auto/example
, in addition to the labelexport: myhostname.com:/exports/example
It looks like this is already supported by procfs: https://github.com/prometheus/procfs/blob/master/mountstats.go#L314
The text was updated successfully, but these errors were encountered: