fixup! collector/diskstats: add block device rotational

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
prometheus · Sep 22, 2024 · 5b2f567 · 5b2f567
1 parent 50e3424
commit 5b2f567
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/collector/fixtures/e2e-64k-page-output.txt b/collector/fixtures/e2e-64k-page-output.txt
@@ -622,6 +622,23 @@ node_disk_reads_merged_total{device="sdb"} 841
 node_disk_reads_merged_total{device="sdc"} 141
 node_disk_reads_merged_total{device="sr0"} 0
 node_disk_reads_merged_total{device="vda"} 15386
+# HELP node_disk_rotational Rotational indicates whether the device is a rotational disk (1) or not (0).
+# TYPE node_disk_rotational gauge
+node_disk_rotational{device="dm-0"} 0
+node_disk_rotational{device="dm-1"} 0
+node_disk_rotational{device="dm-2"} 0
+node_disk_rotational{device="dm-3"} 0
+node_disk_rotational{device="dm-4"} 0
+node_disk_rotational{device="dm-5"} 0
+node_disk_rotational{device="mmcblk0"} 0
+node_disk_rotational{device="mmcblk0p1"} 0
+node_disk_rotational{device="mmcblk0p2"} 0
+node_disk_rotational{device="nvme0n1"} 0
+node_disk_rotational{device="sda"} 1
+node_disk_rotational{device="sdb"} 0
+node_disk_rotational{device="sdc"} 0
+node_disk_rotational{device="sr0"} 0
+node_disk_rotational{device="vda"} 0
 # HELP node_disk_write_time_seconds_total This is the total number of seconds spent by all writes.
 # TYPE node_disk_write_time_seconds_total counter
 node_disk_write_time_seconds_total{device="dm-0"} 1.1585578e+06

diff --git a/collector/fixtures/e2e-output.txt b/collector/fixtures/e2e-output.txt
@@ -644,6 +644,23 @@ node_disk_reads_merged_total{device="sdb"} 841
 node_disk_reads_merged_total{device="sdc"} 141
 node_disk_reads_merged_total{device="sr0"} 0
 node_disk_reads_merged_total{device="vda"} 15386
+# HELP node_disk_rotational Rotational indicates whether the device is a rotational disk (1) or not (0).
+# TYPE node_disk_rotational gauge
+node_disk_rotational{device="dm-0"} 0
+node_disk_rotational{device="dm-1"} 0
+node_disk_rotational{device="dm-2"} 0
+node_disk_rotational{device="dm-3"} 0
+node_disk_rotational{device="dm-4"} 0
+node_disk_rotational{device="dm-5"} 0
+node_disk_rotational{device="mmcblk0"} 0
+node_disk_rotational{device="mmcblk0p1"} 0
+node_disk_rotational{device="mmcblk0p2"} 0
+node_disk_rotational{device="nvme0n1"} 0
+node_disk_rotational{device="sda"} 1
+node_disk_rotational{device="sdb"} 0
+node_disk_rotational{device="sdc"} 0
+node_disk_rotational{device="sr0"} 0
+node_disk_rotational{device="vda"} 0
 # HELP node_disk_write_time_seconds_total This is the total number of seconds spent by all writes.
 # TYPE node_disk_write_time_seconds_total counter
 node_disk_write_time_seconds_total{device="dm-0"} 1.1585578e+06