Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 2 additional metrics #184

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

tnosaj
Copy link
Contributor

@tnosaj tnosaj commented Oct 5, 2023

@grobie

This is a pretty small change that adds 2 new metrics for debugging errors on store operations based on the output of the stats page:

  • store_no_memory
# HELP memcached_item_no_memory The number of times an item could not be stored due to no more memory.
# TYPE memcached_item_no_memory counter
memcached_item_no_memory 0
  • store_too_large
# HELP memcached_item_too_large The number of times an item exceeded the max-item-size when being stored.
# TYPE memcached_item_too_large counter
memcached_item_too_large 1

I followed the format of the other metrics but was not sure about the ordering in the lists - i added these two metrics where i thought they fit most, but am happy to make any changes if needed.

Thank you!

Signed-off-by: Jason Tevnan <jason.tevnan@gmail.com>
@tnosaj tnosaj force-pushed the jt/add-store_too_large-stat branch from f08f237 to 7534f23 Compare October 5, 2023 11:17
@matthiasr
Copy link
Contributor

Thank you!

@matthiasr matthiasr merged commit 5dab939 into prometheus:master Dec 6, 2023
3 checks passed
matthiasr referenced this pull request Dec 6, 2023
maintenance release

Signed-off-by: Matthias Rampke <matthias@prometheus.io>
@tnosaj tnosaj deleted the jt/add-store_too_large-stat branch December 6, 2023 10:39
matthiasr added a commit that referenced this pull request Dec 6, 2023
Fixup for #184: these are counters, so we should name them accordingly.

Signed-off-by: Matthias Rampke <matthias@prometheus.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants