Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export extstore_io_queue gauge #169

Merged
merged 2 commits into from
May 23, 2023
Merged

Export extstore_io_queue gauge #169

merged 2 commits into from
May 23, 2023

Conversation

dannykopping
Copy link
Contributor

Also exported extstore_pages_free which seems to have been missed previously

Danny Kopping added 2 commits May 4, 2023 20:06
Add extstore_io_queue metric to track pending disk operations
bbd9263 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Parsing missing extstore_pages_free metric
b6fd04a 
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping
Copy link
Contributor Author

@grobie can you please take a look at this?

@dannykopping
Copy link
Contributor Author

@grobie just checking in: can you please review & merge this? It's currently blocking us

SuperQ
SuperQ approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 8cbc5c9 into prometheus:master May 23, 2023
@dannykopping dannykopping deleted the io_queue branch May 23, 2023 11:58
@dannykopping
Copy link
Contributor Author

@SuperQ many thanks 👍
How often do you folks cut patch releases?

@SuperQ
Copy link
Member

SuperQ commented May 23, 2023

Usually as needed / as we have time. This exporter is pretty simple and has few changes. Should be able to do one soon.

@dannykopping
Copy link
Contributor Author

Great, thanks!

@dannykopping dannykopping mentioned this pull request Jun 2, 2023
Merged
SuperQ added a commit that referenced this pull request Jun 2, 2023
@SuperQ
Release 0.12.0
784c1a1 
* [ENHANCEMENT] Add `memcached_extstore_io_queue_depth` #169
* [BUGFIX] Fix exposing `memcached_extstore_pages_free` #169

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Jun 2, 2023
@SuperQ
Release 0.12.0
186fbd8 
* [ENHANCEMENT] Add `memcached_extstore_io_queue_depth` #169
* [BUGFIX] Fix exposing `memcached_extstore_pages_free` #169

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannykopping @SuperQ