Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hbase.yaml #459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hbase.yaml #459

wants to merge 1 commit into from

Conversation

tgunkel
Copy link

@tgunkel tgunkel commented Jan 24, 2020

For the HBase database I needed a config file. Found one here https://blog.godatadriven.com/hbase-prometheus-monitoring but it could not handle _ in table names.

For the HBase database I needed a config file. Found one here https://blog.godatadriven.com/hbase-prometheus-monitoring but it could not handle _ in table names.
Copy link
Contributor

@brian-brazil brian-brazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share example /metrics output?

namespace: "$1"
table: "$2"
region: "$3"
value: "$5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you not leaving this to the default?

# Idea came from https://blog.godatadriven.com/hbase-prometheus-monitoring
rules:
- pattern: Hadoop<service=HBase, name=RegionServer, sub=Regions><>Namespace_(.+)_table_(.+)_region_(.+)_metric_(.+):\ (.+)
name: HBase_metric_$4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metric is redundant here

we also go with lowercase, so hbase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be added so that it does not overwrite other metrics which may overlap or have different type.

for example in HBase you can have already generated metric named Hbase_active: 1.0

Then there is some hbase data with below structure (abbreviated)
...Namespace_test_table_meta_region_abc_metric_get: 20
and which would produce Hbase_active with labels namespace=test,table=meta,region=abc with value 20.0

In that case it would cause metric clash.

I would keep lowercase, as suggested.

@@ -0,0 +1,13 @@
# The metrics look this this
# Hadoop<service=HBase, name=RegionServer, sub=Regions><>Namespace_foo_table_my_table_name_region_1234567xy_metric_scanNext_75th_percentile: 0.0
# So we have many many different metrics and it is hard to aggregate per namespace or per table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this comment, this is the usual way to do things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants