Add softether_exporter #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! I think you have your counters and gauges a bit mixed up. Counters should end in _total, and Gauges should not. In addition you are using direct instrumentation for an exporter, which is not the best way to go about it. Instead you should use a custom collector and only create the metric families on each scrape. See https://www.robustperception.io/writing-json-exporters-in-python/ for example. |
Contributor
Author
|
Thank you for your advise. |
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SoftEther VPN server (http://www.softether.org) exporter to list