clarify gce sd config when meta data is returning urls as values #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * `__meta_gce_zone`: the GCE zone in which the instance is running | ||
| * `__meta_gce_zone`: the GCE zone URL in which the instance is running | ||
|
|
||
| For meta labels returning an URL the format is as follows: |
Contributor
There was a problem hiding this comment.
This may change due to no action on our part, so this shouldn't be documented here. We don't want GCE to cause what counts as a breaking change in Prometheus.
Contributor
Author
There was a problem hiding this comment.
I agree. I still think it's most intuitive if it does not return urls in the first place.
Contributor
There was a problem hiding this comment.
You are free to take that up with GCE. Please remove this section.
Contributor
|
Thanks! |
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
* tools, readme: add DM task management doc Via: https://github.com/pingcap/tidb-tools/blob/docs/docs/dm/zh_CN/task-handling/dmctl-manual.md, https://github.com/pingcap/tidb-tools/blob/docs/docs/dm/zh_CN/task-handling/task-commands.md * tools: update wording * tools: address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue prometheus/prometheus#3042