fix(nh-spec): update histogram_quantile and histogram_fraction docs #2676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
force-pushed
the
krajo/nh-quantile-nan
branch
2 times, most recently
from
c490d2a to
52b700e
Compare
krajorama
changed the title
Fix TODOs. And align with new implementation. Related to prometheus/prometheus#16578 Related to prometheus/prometheus#16724 Related to prometheus/prometheus#16580 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/nh-quantile-nan
branch
from
52b700e to
7fe1fd3
Compare
carrieedwards
approved these changes
Jun 15, 2025
beorn7
requested changes
Jun 18, 2025
| with how classic histograms usually treat `NaN` observations (which end up in | ||
| the `+Inf` bucket in most implementations). If the quantile falls above all | ||
| existing buckets, we return `NaN` due to the fact that we want to be consistent | ||
| with `histogram_fraction`, since `histogram_fraction` considers `NaN` |
There was a problem hiding this comment.
Maybe turn this comma into a semicolon or period? It's hard to dissect this sentence currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TODOs.
Related to prometheus/prometheus#16578
Related to prometheus/prometheus#16724
Related to prometheus/prometheus#16580