grafana_dashboards variable #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sdarwin <samuel.d.darwin@gmail.com>
SuperQ
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier version of demo-site included the variable
grafana_dashboards: []which I thought was a nice reminder of what the variable name is and that it should probably be configured. We are usinggrafana_dashboards.If you do set that variable now, the grafana role complains
grafana_datasourcesis missing.Based on that discovery, it seems the renaming of
grafana_datasourcestodatasourcesin this vars.yml file didn't match the upstream grafana role and so maybe "datasources" is being ignored.This PR partially reverts the file
group_vars/grafana/vars.ymlto a previous state. Things are working better. but if you believe I am missing other details about the topic and this is incorrect, let me know.